Repository navigation
Fix deque repr to print correct format - #3218
Merged
Merged
Conversation
lijm1358
changed the title
repr to print correct format
youknowone
reviewed
Oct 4, 2021
| format!("deque([{}]{})", elements.into_iter().format(", "), maxlen) | ||
| format!( | ||
| "{}([{}]{})", | ||
| zelf.class().slot_name(), |
Member
There was a problem hiding this comment.
I don't know well about this spec. is this not zelf.class().name() but zelf.class().slot_name()?
Contributor
Author
There was a problem hiding this comment.
First thought name() and slot_name() showed the same value, but name() returning self.slot_name().rsplit('.').next().unwrap().to_string() looks more good to me now. Thanks for reviewing!
youknowone
approved these changes
Oct 4, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
PyDeque.reprin #3217before
after