Repository navigation
Remove not very useful iterator utilty functions - #3202
Merged
Merged
Conversation
youknowone
marked this pull request as draft
October 2, 2021 18:09
youknowone
force-pushed
the
pyiter-more
branch
from
October 2, 2021 18:56
f93b741 to
6b046ee
Compare
youknowone
marked this pull request as ready for review
October 2, 2021 20:11
youknowone
force-pushed
the
pyiter-more
branch
from
October 3, 2021 19:54
709d925 to
0576b2b
Compare
Member
|
Right, was going to ask, does this supersede #3183 or are you still planning on merging that too? |
Member
Author
|
either way ok by review convenience |
DimitrisJim
approved these changes
Oct 4, 2021
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
There was a problem hiding this comment.
looks great to me, quick timings show me there's also a slight performance gain too.
Member
Author
|
yes, though it is just a little bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #3183