Repository navigation
Fix pystruct incompatibility and Add test_buffer.py from cpython 3.8 - #3196
Merged
Merged
Conversation
Signed-off-by: snowapril <sinjihng@gmail.com>
Signed-off-by: snowapril <sinjihng@gmail.com>
test_buffer.py from cpython 3.8test_buffer.py from cpython 3.8
youknowone
approved these changes
Oct 2, 2021
Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril
force-pushed
the
fix_pystruct
branch
from
October 2, 2021 11:38
1a152a2 to
c5cc179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision fix the incompatibility behaviour in
pystructand addtest_buffer.pyfrom cpython 3.8.There exists incompatibility when overflow occurred in
struct.pack. Here is examplecpython
rustpython
This minor difference make
test_buffer.pystalled in this lines.test_buffer.pyis usestructand_testbuffermodule which is not yet implemented. Thus this test will be skipped in defaultIn addition,
test_add_file_after_2107intest_zipfile.pyandtest_b85decode_errors&test_a85decode_errorsintest_base64.pynow going works