Repository navigation
underscore issue on parse_str - #3194
Closed
eunsung-lim wants to merge 2 commits into
Closed
eunsung-lim wants to merge 2 commits into
eunsung-lim wants to merge 2 commits into
Conversation
youknowone
requested changes
Oct 2, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
By this change, you turned a few tests to pass. Removing unittest.expectedFailure from those tests will make your PR pass tests
Member
|
could you run fmt and push it again? |
Member
|
@eunsung-lim will you going to finish this PR? let me know if you don't want anymore. |
Member
|
Thanks, not quite sure unfortunately when, but this currently behaves as expected (code currently resides in the Parser repository). Thanks for the PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parssing string to float, strings with underscores need to raise error
ex. "1_e1"