Repository navigation
use PyIterReturn for gen internal - #3183
Closed
youknowone wants to merge 2 commits into
Closed
youknowone wants to merge 2 commits into
youknowone wants to merge 2 commits into
Conversation
youknowone
marked this pull request as draft
October 1, 2021 19:38
youknowone
force-pushed
the
iter-return
branch
5 times, most recently
from
October 1, 2021 21:37
7e39271 to
f2f95fd
Compare
youknowone
marked this pull request as ready for review
October 1, 2021 21:38
DimitrisJim
reviewed
Oct 1, 2021
| pub struct Coro { | ||
| frame: FrameRef, | ||
| pub closed: AtomicCell<bool>, | ||
| pub closed: AtomicCell<bool>, // redudant? |
Member
There was a problem hiding this comment.
If frame was made into an option closed could be removed. That's closer to what CPython does.
Member
Author
There was a problem hiding this comment.
I replaced this comment to link to this comment
Member
|
merged #3185 first so other PRs that might come before this is merged won't get stuck on the failing tests. |
youknowone
force-pushed
the
iter-return
branch
from
October 2, 2021 04:40
f2f95fd to
e547ca3
Compare
youknowone
force-pushed
the
iter-return
branch
from
October 2, 2021 07:36
e547ca3 to
3eec37b
Compare
youknowone
force-pushed
the
iter-return
branch
from
October 2, 2021 08:11
3eec37b to
198a2b3
Compare
Member
Author
|
merged by #3202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.