Skip to content

pub(crate) for type modules#3169

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:hide-type-modules
Oct 2, 2021
Merged

pub(crate) for type modules#3169
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:hide-type-modules

Conversation

@youknowone

Copy link
Copy Markdown
Member

there are no pub free functions exposed in this way.

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, have you investigated why android complains for the check?

@youknowone

youknowone commented Oct 1, 2021

Copy link
Copy Markdown
Member Author

No I didn't. I think it is just simply because android is not using PyMapping somewhere. Those stuff will be completely removed by #3121. So they will not be a problem anymore.

To make warnings clear, I will merge this PR once after #3121 is done.

@youknowone youknowone merged commit e27b9ae into RustPython:main Oct 2, 2021
@youknowone youknowone deleted the hide-type-modules branch October 2, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants