Repository navigation
int::try_to_primitive -> PyInt::try_to_primitive - #3142
Merged
Merged
Conversation
youknowone
force-pushed
the
int-primitive
branch
from
September 26, 2021 03:45
3b205e2 to
71b408a
Compare
youknowone
force-pushed
the
int-primitive
branch
from
September 26, 2021 04:22
71b408a to
4650b30
Compare
DimitrisJim
reviewed
Sep 27, 2021
| impl_into_pyobject_int!(isize i8 i16 i32 i64 usize u8 u16 u32 u64 BigInt); | ||
|
|
||
| pub fn try_to_primitive<'a, I>(i: &'a BigInt, vm: &VirtualMachine) -> PyResult<I> | ||
| pub(crate) fn try_to_primitive<'a, I>(i: &'a BigInt, vm: &VirtualMachine) -> PyResult<I> |
Member
There was a problem hiding this comment.
is this used elsewhere in the crate after this change? If not, why not make it private?
Member
Author
There was a problem hiding this comment.
vm/src/iterator.rs uses it
Member
There was a problem hiding this comment.
seems like that place can easily be changed to accommodate this change, either the case, this lgtm, I'll leave the choice of if you want to change it up to you.
Member
Author
There was a problem hiding this comment.
I think this is still related to stdlib work. let me clean it up with it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.