Exception utils as vm methods#3133
Merged
youknowone merged 1 commit intoOct 13, 2021
Merged
Conversation
youknowone
force-pushed
the
exception-utils-as-vm-methods
branch
2 times, most recently
from
ffd9379 to
5a5f77c
Compare
youknowone
force-pushed
the
exception-utils-as-vm-methods
branch
from
5a5f77c to
98dcf60
Compare
youknowone
force-pushed
the
exception-utils-as-vm-methods
branch
from
98dcf60 to
3954433
Compare
youknowone
force-pushed
the
exception-utils-as-vm-methods
branch
from
3954433 to
256de1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #3131Why putting these functions in
impl VirtualMachinebut not inimpl PyException?These functions are natively free function in CPython - not methods of PyException.
On the other hand,
VirtualMachinealready includes a lot of public CPython utility functions related to vm.