rustpython-stdlib crate#3129
Merged
Merged
Conversation
youknowone
force-pushed
the
rustpython-stdlib
branch
3 times, most recently
from
35e2dc0 to
90c1972
Compare
youknowone
force-pushed
the
rustpython-stdlib
branch
6 times, most recently
from
2280760 to
0db8589
Compare
Member
Author
|
done except for windows |
youknowone
force-pushed
the
rustpython-stdlib
branch
4 times, most recently
from
c67d1f6 to
d27785a
Compare
This was referenced Sep 27, 2021
youknowone
force-pushed
the
rustpython-stdlib
branch
from
d27785a to
f89e440
Compare
DimitrisJim
reviewed
Sep 27, 2021
youknowone
force-pushed
the
rustpython-stdlib
branch
9 times, most recently
from
31f2ac1 to
8fc0025
Compare
youknowone
force-pushed
the
rustpython-stdlib
branch
from
8fc0025 to
41b0c2e
Compare
Member
Author
|
@DimitrisJim @coolreader18 there will be more things to do (e.g. corelib), but I want to finish this PR for current state and do further works later. |
youknowone
force-pushed
the
rustpython-stdlib
branch
from
41b0c2e to
663cea8
Compare
youknowone
commented
Sep 30, 2021
| #[cfg(all(unix, not(target_os = "redox")))] | ||
| mod termios; | ||
|
|
||
| use rustpython_common as common; |
Member
Author
There was a problem hiding this comment.
is this intended to be used like vm::common?
youknowone
force-pushed
the
rustpython-stdlib
branch
from
663cea8 to
fb25a15
Compare
coolreader18
approved these changes
Sep 30, 2021
Member
|
LGTM! |
DimitrisJim
approved these changes
Sep 30, 2021
This was referenced Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3102