Skip to content

PyIter protocol object#3117

Merged
DimitrisJim merged 2 commits into
RustPython:mainfrom
youknowone:pyiter-protocol
Sep 29, 2021
Merged

PyIter protocol object#3117
DimitrisJim merged 2 commits into
RustPython:mainfrom
youknowone:pyiter-protocol

Conversation

@youknowone

@youknowone youknowone commented Sep 22, 2021

Copy link
Copy Markdown
Member

based on #3115 and #3116

will be part of #3104 because PyIter is required for stdlib modules

@youknowone youknowone changed the title Pyiter protocol PyIter protocol object Sep 23, 2021
@youknowone youknowone force-pushed the pyiter-protocol branch 4 times, most recently from 750687e to f965792 Compare September 27, 2021 16:13
@youknowone

youknowone commented Sep 29, 2021

Copy link
Copy Markdown
Member Author

@DimitrisJim could you review this PR? First commit is simple type name replacement. Second commit is actual protocol implementation

Comment thread vm/src/iterator.rs
Comment thread vm/src/protocol/iter.rs
Comment thread vm/src/stdlib/operator.rs Outdated

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DimitrisJim DimitrisJim merged commit a3c06d9 into RustPython:main Sep 29, 2021
@youknowone youknowone deleted the pyiter-protocol branch September 30, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants