Skip to content

rustpython-vm public API for rustpython-stdlib#3104

Closed
youknowone wants to merge 7 commits into
RustPython:mainfrom
youknowone:public-api
Closed

rustpython-vm public API for rustpython-stdlib#3104
youknowone wants to merge 7 commits into
RustPython:mainfrom
youknowone:public-api

Conversation

@youknowone

Copy link
Copy Markdown
Member

ref #3102

Comment thread vm/src/builtins/mod.rs
Comment thread vm/src/builtins/mod.rs Outdated
pub use zip::PyZip;
pub(crate) mod genericalias;

pub use super::exceptions::{PyBaseException, PyBaseExceptionRef};

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the view of public API, these types are not distinguishable with other built-in types

Comment thread vm/src/lib.rs Outdated
Comment on lines +81 to +83
pub mod protocols {
pub use super::buffer::{PyBuffer, PyBufferInternal};
pub use super::slots::PyIter;
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new module protocols for python c-api protocols

Comment thread vm/src/builtins/pybool.rs Outdated
@youknowone youknowone force-pushed the public-api branch 2 times, most recently from 2552210 to f9eedf5 Compare September 25, 2021 20:00
@youknowone youknowone mentioned this pull request Sep 25, 2021
@youknowone youknowone force-pushed the public-api branch 2 times, most recently from e6c39ad to 03d513f Compare September 25, 2021 21:06
This was referenced Sep 26, 2021
@youknowone youknowone mentioned this pull request Sep 26, 2021
@youknowone youknowone marked this pull request as ready for review September 27, 2021 17:29
@youknowone youknowone force-pushed the public-api branch 5 times, most recently from 9d4e9ee to 2b822ff Compare September 29, 2021 18:21
@youknowone

Copy link
Copy Markdown
Member Author

merged as part of #3129

@youknowone youknowone closed this Oct 1, 2021
@youknowone youknowone deleted the public-api branch October 1, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants