Repository navigation
os: fix stat_result test - #3088
Merged
Merged
Conversation
youknowone
reviewed
Sep 18, 2021
Comment on lines
+1127
to
+1129
| if vec_args.len() == 1 { | ||
| // SAFETY: len is check in previous line | ||
| let obj = vec_args.first().unwrap(); |
Member
There was a problem hiding this comment.
Suggested change
| if vec_args.len() == 1 { | |
| // SAFETY: len is check in previous line | |
| let obj = vec_args.first().unwrap(); | |
| if let Some(obj) = vec_args.iter().exactly_one() { |
Contributor
Author
There was a problem hiding this comment.
@youknowone Thanks for the suggestion! Will change this as suggested.
deantvv
force-pushed
the
os-stat-result
branch
2 times, most recently
from
September 18, 2021 15:57
6834fc9 to
380d518
Compare
Implement tp_new for `stat_result` To unpack args, this PR implement a `flatten_args` closure to unpack args like ``` args = (1, 2, 3, 4, 5) args = ((1, 2, 3, 4, 5)) args = (((1, 2, 3, 4, 5))) # from pickle load ```
deantvv
force-pushed
the
os-stat-result
branch
from
September 19, 2021 02:08
380d518 to
96dcd68
Compare
youknowone
approved these changes
Sep 19, 2021
youknowone
approved these changes
Sep 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement tp_new for
stat_resultTo unpack args, this PR implement a
flatten_argsclosure tounpack args like