revise PySuper::getattro same as CPython super_getattro#3058
Merged
Conversation
youknowone
force-pushed
the
super-getattro
branch
from
65971c1 to
28b1340
Compare
youknowone
changed the title
Member
Author
|
@eldpswp99 could you review this PR? I think you also reviewed cpython super_getattro |
eldpswp99
approved these changes
Sep 15, 2021
Contributor
|
Does this affect the results of |
youknowone
force-pushed
the
super-getattro
branch
from
28b1340 to
d4f925a
Compare
Member
Author
|
rebased it onto test_super.py but nothing changed. |
DimitrisJim
approved these changes
Sep 16, 2021
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
There was a problem hiding this comment.
making the names follow the ones used in CPython made this easy to review. p.s the soundforge bug report (SF ID #743627) is actually a dead-end, probably a relic left over in the CPython code.
youknowone
force-pushed
the
super-getattro
branch
from
d4f925a to
cfc5163
Compare
Member
Author
|
I replaced it to alive link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
possibly related to #3057 but didn't solve the problem itself