Implemented sqrt for cmath - #3047

i ran the test but couldnt unserstand the output

I don't believe we're currently at the point where we can confidently test your code just by running the CPython test suite (see these lines of test_cmath.py). Perhaps, in the interim, we could put some temporary tests in the extra_tests/snippets/ directory.

@fanninpm In this case, I think we'd better to edit the test file to run actual test rather than adding our own test. The running is suppressed but there is already tests

a tip for new open source contributors: never use git merge or git pull. we only need git fetch and git rebase. (or git pull --rebase, but too easy to make mistake)

Fixed up the tests a bit to allow sqrt to run, I'll take care of the other PRs too and (when they all hopefully finish) bring test_cmath to its original form.

Fixed up the tests a bit to allow sqrt to run, I'll take care of the other PRs too and (when they all hopefully finish) bring test_cmath to its original form.

Hi @DimitrisJim , I'm about to raise a PR for acos and acosh implementation, were these comments in the test file suggested by you to @Codemonk-adi ?

Should I wait for his PR to be merged?

Should I wait for his PR to be merged?

Yup. Lets wait and see how we'll be running the tests. I'm personally open to either having a new variable or doing it as I've currently done. Since I'll try and follow most PRs for cmath.rs I think I can keep track of things whatever the case.

@youknowone opinions here?

My suggestion is replcing line 331 like below:

            complex_fn = getattr(cmath, fn, None)
            if complex_fn is None:
                continue

Then newly added function always will be tested but no error will be raised for not added one.
We can finally remove it when every functions are finally added.

Yup, that was a better idea. (Ref #3039 to keep track of the PRs.)

@Codemonk-adi user.email doesn't look correctly set

@youknowone
I did git config --global user.name "Codemonk-adi"
and then pushed, can you pls tell me what should I do?

@Codemonk-adi You should also set git config --global user.email "your email" then problems will be disappeared 😊