Skip to content

Bump recursion limit to match CPython's #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 1 commit into from
Aug 27, 2021
Merged

Bump recursion limit to match CPython's #2976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Lib/test/test_threading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,13 @@ def test_recursion_limit(self):
# for threads
script = """if True:
import threading
# TODO: RUSTPYTHON
# Following lines set the recursion limit to previous default of 512
# for the execution of this process. Without this, the test runners
# on Github fail. Ideally, at a future point this should be removed.
import os, sys
if os.getenv("CI"):
sys.setrecursionlimit(512)

@DimitrisJim DimitrisJim Aug 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was setting it at the wrong place before since I didn't notice a new process is being spawned here. By modifying the
recursion limit inside the script that's executed, it seems to handle things just fine.


def recurse():
return recurse()
Expand Down
2 changes: 1 addition & 1 deletion vm/src/vm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ impl VirtualMachine {
profile_func,
trace_func,
use_tracing: Cell::new(false),
recursion_limit: Cell::new(if cfg!(debug_assertions) { 256 } else { 512 }),
recursion_limit: Cell::new(if cfg!(debug_assertions) { 256 } else { 1000 }),
signal_handlers: Some(Box::new(signal_handlers)),
repr_guards: RefCell::default(),
state: PyRc::new(PyGlobalState {
Expand Down