Skip to content

Bump recursion limit to match CPython's - #2976

Merged
youknowone merged 1 commit into
RustPython:mainfrom
DimitrisJim:bump_recursion_limit
Aug 27, 2021
Merged

youknowone merged 1 commit into
RustPython:mainfrom
DimitrisJim:bump_recursion_limit

Conversation

@DimitrisJim

@DimitrisJim DimitrisJim commented Aug 27, 2021 •

Copy link
Copy Markdown
Member

Closes #2948

Second attempt at this. Just noticed a new process is spawned so the increase needs to be done in the script executed.

# on Github fail. Ideally, at a future point this should be removed.
import os, sys
if os.getenv("CI"):
sys.setrecursionlimit(512)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I was setting it at the wrong place before since I didn't notice a new process is being spawned here. By modifying the
recursion limit inside the script that's executed, it seems to handle things just fine.

@DimitrisJim
DimitrisJim requested a review from youknowone August 27, 2021 07:15
@youknowone
youknowone merged commit 3a861e4 into RustPython:main Aug 27, 2021
@DimitrisJim
DimitrisJim deleted the bump_recursion_limit branch November 7, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python-speed failing to run

2 participants