Repository navigation
Bump recursion limit to match CPython's - #2959
DimitrisJim wants to merge 1 commit into
Conversation
|
Locally, this is fine. Seems like the test runners aren't able to handle it though. Closing for now since I'm pretty sure 1000 is considered an implementation detail at the end of the day. |
|
https://docs.python.org/3/library/sys.html#sys.setrecursionlimit I think default value can be 1000 and we can override it for CI |
|
But where would I set it? The only place I can think of is in the failing function along with a |
|
I am thinking of |
5d7cfe8 to
d822964
Compare
d822964 to
a68c521
Compare
|
I cant diagnore the issue here. Trying to set the recursion limit doesn't seem to do the trick either. |
|
I think sys.setrecursionlimit in RustPython doesn't work perfectly. It copies the value to threads, but I think sys.recursionlimit is a shared value between threads |
This was set in #1477 to 512 though 1000 appears to easily be supported as a default. This matches the value currently used by CPython and closes #2948