Repository navigation
added __add__ method to collections.deque - #2949
Merged
Merged
Conversation
Member
|
@eldpswp99 would you review this PR? |
eldpswp99
suggested changes
Aug 24, 2021
eldpswp99
left a comment
eldpswp99
left a comment
Contributor
There was a problem hiding this comment.
since we have extend function of PyDeque, we can use this. This has length check logic, the code can be more clear.
eldpswp99
suggested changes
Aug 24, 2021
DimitrisJim
self-requested a review
August 24, 2021 03:44
DimitrisJim
previously requested changes
Aug 24, 2021
Member
|
Thanks for updating this, could you resolve the conflicts that have come up? |
DimitrisJim
approved these changes
Aug 25, 2021
DimitrisJim
left a comment
DimitrisJim
left a comment
Member
There was a problem hiding this comment.
lgtm. not sure why the option to run the actions isn't showing for me though.
Contributor
Is it because of the merge commit? Perhaps a rebase is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #2835
add
deque.__add__method