Skip to content

add deque __bool__ method - #2931

Merged
DimitrisJim merged 3 commits into
RustPython:mainfrom
OhBonsai:master
Aug 24, 2021
Merged

DimitrisJim merged 3 commits into
RustPython:mainfrom
OhBonsai:master

Conversation

@OhBonsai

@OhBonsai OhBonsai commented Aug 22, 2021 •

Copy link
Copy Markdown
Contributor

closes #2837

Comment thread Lib/test/test_deque.py Resolved
Comment thread vm/src/stdlib/collections.rs Resolved
@fanninpm

fanninpm commented Aug 23, 2021 •

Copy link
Copy Markdown
Contributor

Just a heads up: if you word your PR description such that it contains these magic words, GitHub will automatically close the linked issue when the PR gets merged.

@DimitrisJim
DimitrisJim dismissed youknowone’s stale review August 24, 2021 05:29

Author removed the extra tests in test_deque.

@DimitrisJim
DimitrisJim merged commit e66566f into RustPython:main Aug 24, 2021
@DimitrisJim

Copy link
Copy Markdown
Member

Thanks for the contribution! 🎉

eldpswp99 pushed a commit to eldpswp99/RustPython that referenced this pull request Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

collections.deque doesn't have a __bool__ method.

4 participants