make dict iterator use atomic operation#2927
Merged
youknowone merged 2 commits intoAug 22, 2021
Merged
Conversation
youknowone
requested review from
DimitrisJim,
coolreader18 and
youknowone
and removed request for
youknowone
coolreader18
approved these changes
Aug 22, 2021
coolreader18
left a comment
coolreader18
left a comment
Member
There was a problem hiding this comment.
Nice! This is definitely better.
| } | ||
| } | ||
|
|
||
| pub fn next_entry(&self, position: &AtomicCell<usize>) -> Option<(PyObjectRef, T)> { |
Member
There was a problem hiding this comment.
Maybe this could be named next_entry_atomic?
Contributor
Author
There was a problem hiding this comment.
Is it better to revert _next_entry to next_entry when I change the function name to next_entry_atomic?
Contributor
Author
There was a problem hiding this comment.
@coolreader18 I sent new code with changing function name!
youknowone
reviewed
Aug 22, 2021
youknowone
force-pushed
the
make-dict-iterator-use-atomic-operation
branch
from
a75c279 to
19ce637
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #2915, there was a comment to use only fetch_add, not using load & store to maintain atomic operation.
since dict iterator has this load & store, change to use fetch_add.