adjust dict reverse iterator next to new dict entries structure#2915
Merged
youknowone merged 2 commits intoAug 21, 2021
Merged
Conversation
youknowone
reviewed
Aug 20, 2021
Comment on lines
+785
to
+788
| let mut position = zelf.position.load(); | ||
| match zelf.dict.entries.next_entry_reversed(&mut position) { | ||
| Some((key, value)) => { | ||
| zelf.position.store(position); |
Member
There was a problem hiding this comment.
fetch_add was atomic operation, but the combination of load and store is not. Can we express this as consecutive fetch_add?
Contributor
Author
There was a problem hiding this comment.
i fixed this with only using fetch_add in next_entry_reversed. there exists same problem in dict iterator, i would fix it in another PR since this PR is about reverse iterator.
youknowone
approved these changes
Aug 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dict entries was changed due to remain order even when delete any element. #2902
in this PR, i only adjust dict reverse iterator next function to this new dict entries structure.
however, there remains some issue about detecting the change while iteration.
before, the size change was equivalent to the change of the dictionary entries, so it was easy to detect it
however, making deletion not to erase entries, and insertion occurs on next_new_entry_idx, it is hard to detect change during iteration.
all iterators with dict may have this issue.