Skip tests that cause RustPython to hang.#2905
Merged
Merged
Conversation
Member
Author
|
|
youknowone
reviewed
Aug 18, 2021
| self.assertFalse(result[0]) | ||
| lock.release() | ||
|
|
||
| @unittest.skip("TODO: RUSTPYTHON hangs") |
Member
There was a problem hiding this comment.
Suggested change
| @unittest.skip("TODO: RUSTPYTHON hangs") | |
| @unittest.skip("TODO: RUSTPYTHON occasionally hangs") |
Probably the word occasional will be helpful to prevent removing skip again before fixing it correctly
Member
There was a problem hiding this comment.
ah, @fanninpm already did it in different PR. how about just pulling it?
Contributor
There was a problem hiding this comment.
@youknowone I'm okay with you and/or @DimitrisJim cherry-picking those commits.
youknowone
previously approved these changes
Aug 18, 2021
youknowone
force-pushed
the
skip_deadlocks
branch
from
0e24698 to
d64cf86
Compare
youknowone
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily so that other PRs don't get stalled until its fixed. Note that these don't hang consistently, they do hang often, though.