Skip to content

Add syntax error detection routine for global symbol #2903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Aug 17, 2021
Merged

Add syntax error detection routine for global symbol #2903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13bbefd
compiler: impl syntax error detect for global kind
Snowapril Aug 17, 2021
38237c3
compiler: add is_global() check at top of errors
Snowapril Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Lib/test/test_syntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,6 @@ def test_assign_call(self):
def test_assign_del(self):
self._check_error("del f()", "delete")

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_global_param_err_first(self):
source = """if 1:
def error(a):
Expand Down
34 changes: 30 additions & 4 deletions compiler/src/symboltable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,10 +1121,36 @@ impl SymbolTableBuilder {
match role {
SymbolUsage::Global => {
if !symbol.is_global() {

@youknowone youknowone Aug 17, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this if statement on the top of these errors. it will decrease hot path cost.

@Snowapril Snowapril Aug 17, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! I agree with that. I sent v2 code.

return Err(SymbolTableError {
error: format!("name '{}' is used prior to global declaration", name),
location,
});
if symbol.is_parameter {
return Err(SymbolTableError {
error: format!("name '{}' is parameter and global", name),
location,
});
}
if symbol.is_referenced {
return Err(SymbolTableError {
error: format!(
"name '{}' is used prior to global declaration",
name
),
location,
});
}
if symbol.is_annotated {
return Err(SymbolTableError {
error: format!("annotated name '{}' can't be global", name),
location,
});
}
if symbol.is_assigned {
return Err(SymbolTableError {
error: format!(
"name '{}' is assigned to before global declaration",
name
),
location,
});
}
}
}
SymbolUsage::Nonlocal => {
Expand Down