Repository navigation
add deque __iadd__ method - #2843
Merged
Merged
Conversation
youknowone
requested changes
Aug 11, 2021
| vm: &VirtualMachine, | ||
| ) -> PyResult<PyRef<Self>> { | ||
| let other: PyObjectRef = if zelf.is(&other) { | ||
| vm.new_pyobj(zelf.copy()) |
Member
There was a problem hiding this comment.
by calling here new_pyobj and calling try_from_object later, this is making unnessessary PyObjectRef.
Contributor
Author
|
the unccessary pyObject was created due to extend bug regard to recursive call , i'll fix extend method first and fix this later |
youknowone
approved these changes
Aug 11, 2021
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Ok, It looks more like extend problem not __iadd__ one. I will merge this PR for now. We can fix it when extend is fixed later.
Thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #2838
add
deque.__iadd__method