Add test_base64 from CPython 3.8.7#2463
Merged
Merged
Conversation
Member
|
I'm not sure if it makes sense to copy this test file yet; the majority of tests are failing or panicking and the underlying rust implementation is just using an external crate, not necessarily attempting to match CPython's behavior. |
Contributor
Author
|
It probably makes sense to defer this PR for the reasons you mentioned above. Perhaps we could revisit this test suite in the future. |
Member
|
I agree adding many |
youknowone
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.