Skip to content

Add test_base64 from CPython 3.8.7#2463

Merged
youknowone merged 3 commits into
RustPython:masterfrom
fanninpm:test-base64
Aug 17, 2021
Merged

Add test_base64 from CPython 3.8.7#2463
youknowone merged 3 commits into
RustPython:masterfrom
fanninpm:test-base64

Conversation

@fanninpm

Copy link
Copy Markdown
Contributor

No description provided.

@coolreader18

Copy link
Copy Markdown
Member

I'm not sure if it makes sense to copy this test file yet; the majority of tests are failing or panicking and the underlying rust implementation is just using an external crate, not necessarily attempting to match CPython's behavior.

@fanninpm

Copy link
Copy Markdown
Contributor Author

It probably makes sense to defer this PR for the reasons you mentioned above. Perhaps we could revisit this test suite in the future.

@youknowone

Copy link
Copy Markdown
Member

I agree adding many unittest.skiped tests doesn't give benefits as much as unittest.expectedFailure marked tests. But still it will show goals for newcomers.

@youknowone youknowone merged commit 77ab21c into RustPython:master Aug 17, 2021
@fanninpm fanninpm deleted the test-base64 branch August 17, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants