Optimize builtins/range#2460
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary operations, such as clone, multiplication, and division.
For the following microbenchmark, the current master would take time
3.41s, 0.73s, 3.69s, and it takes2.27s, 0.50s, 2.60safter applying this patch.Previously, the
PyRange::getfunction takes 30% of the time, and it takes only 10% of execution time after this optimization.Currently, 34% of the time is spent on
PyDict::inner_itemset_fast(a lot of time spent on dropping the old value), and about 10% is spent onBigIntconversion fromusizeand toPyInt.