Skip to content

Implement os.getgrouplist - #2449

Merged
coolreader18 merged 7 commits into
RustPython:masterfrom
kenkoooo:os_getgrouplist
Feb 12, 2021
Merged

coolreader18 merged 7 commits into
RustPython:masterfrom
kenkoooo:os_getgrouplist

Conversation

@kenkoooo

@kenkoooo kenkoooo commented Feb 11, 2021 •

Copy link
Copy Markdown
Contributor

Implement os.getgrouplist.

Ref #1175

Question

Looks like we don't have test_posix.py to check os.getgrouplist. Do we want to copy it from CPython?

@kenkoooo kenkoooo mentioned this pull request Feb 11, 2021
@coolreader18

Copy link
Copy Markdown
Member

Yeah, I think that'd be good! You can follow this blog post to add the unittest file.

@kenkoooo

kenkoooo commented Feb 12, 2021 •

Copy link
Copy Markdown
Contributor Author

Yeah, I think that'd be good! You can follow this blog post to add the unittest file.

Thanks. Let me do that.

@kenkoooo

Copy link
Copy Markdown
Contributor Author

@coolreader18 I copied test_posix.py and edited it as the following:

  • Put expectedFailure to unimplemented features.
  • Put skip to 1 test, which causes panic.
  • Put skip to 1 class, which is an unimplemented macOS feature.

And also I formatted bytecode/src/lib.rs and compiler/src/ir.rs to follow the latest rustfmt, but we still need to fix a lot of places to follow the latest clippy. I guess we want to fix them in another PR.

@coolreader18 coolreader18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@coolreader18
coolreader18 merged commit 6e7de79 into RustPython:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants