Repository navigation
Declare ourselves as Python 3.9 - #2417
Conversation
9089fbe to
6a1b38b
Compare
3b69d03 to
59794cd
Compare
|
What was the rationale for changing the site-packages paths to rustpythonX.Y? pip seems to be hardcoded to install to pythonX.Y and PyPy uses pythonX.Y too. |
|
It seems like pip respects the rustpythonX.Y path in my experience, and I think my motivation was that we don't have anywhere close to full compatibility for many libraries (especially that require native C extensions) so I feel it makes sense to keep them separate, at least for now. |
|
Makes sense. I think the pip behaviour I saw is because there's still a reference to the RustPython/Lib/distutils/sysconfig.py Lines 136 to 138 in 2bcf7d4 and in RustPython/Lib/distutils/command/install.py Lines 30 to 37 in 2bcf7d4 If I change those by hand pip installs to the correct location. |
|
Huh, interesting, it installs to the right place on my machine but feel free to make a PR if that fixes it in your environment. |
Python 3.5 is pretty old at this point, and I think we generally try to keep up with the latest features (e.g. assignment expression, self-documenting fstrings), so I think it makes sense to say we're 3.9. I put 3.8 in the READMEs because I don't think we have full 3.9 compatibility yet and 3.8 is more used, but I'm not really sure if that makes a difference 🤷