Skip to content

Refactor benchmarking suite to use Criterion and add microbenchmarks #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coolreader18 merged 16 commits into from
Dec 14, 2020
Merged

Refactor benchmarking suite to use Criterion and add microbenchmarks #2367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5788e7b
Refactor benchmarking suite to use Criterion
orf Dec 10, 2020
3a85967
Remove dependency
orf Dec 11, 2020
a788df4
Reduce to 30k
orf Dec 11, 2020
6a841c0
Remove pystone second run
orf Dec 11, 2020
184f9aa
Switch to 500
orf Dec 11, 2020
9f04f37
Fix strings
orf Dec 11, 2020
a605b93
Improve benchmarks
orf Dec 11, 2020
1e4fc5c
fmt
orf Dec 11, 2020
e745805
Exclude benchmarks from flake8
orf Dec 11, 2020
c447ffd
Fix loading
orf Dec 11, 2020
bfd05ee
Switch benchmarkid
orf Dec 11, 2020
dde8af1
Add microbenchmarks
orf Dec 13, 2020
eb22ba1
Add microbenchmarks
orf Dec 13, 2020
7818fd2
Fix micro benchmarks
orf Dec 13, 2020
d36e150
Ignore benches
orf Dec 13, 2020
b221dbb
Allow running pystone standalone
coolreader18 Dec 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ jobs:
- name: install flake8
run: python -m pip install flake8
- name: run lint
run: flake8 . --count --exclude=./.*,./Lib,./vm/Lib --select=E9,F63,F7,F82 --show-source --statistics
run: flake8 . --count --exclude=./.*,./Lib,./vm/Lib,./benches/ --select=E9,F63,F7,F82 --show-source --statistics
miri:
name: Run tests under miri
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@ flame.txt
flamescope.json
/wapm.lock
/wapm_packages
/.cargo/config
185 changes: 185 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 15 additions & 4 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ members = [
"derive", "jit", "parser", "vm", "vm/pylib-crate", "wasm/lib",
]

[[bench]]
name = "bench"
path = "./benchmarks/bench.rs"

[features]
default = ["threading", "pylib"]
flame-it = ["rustpython-vm/flame-it", "flame", "flamescope"]
Expand Down Expand Up @@ -48,6 +44,15 @@ rustyline = "6.0"

[dev-dependencies]
cpython = "0.5.0"
criterion = "0.3"

[[bench]]
name = "execution"
harness = false

[[bench]]
name = "microbenchmarks"
harness = false

[[bin]]
name = "rustpython"
Expand All @@ -56,10 +61,16 @@ path = "src/main.rs"
[profile.dev.package."*"]
opt-level = 3

[profile.bench]
lto = true
codegen-units = 1
opt-level = 3

[patch.crates-io]
# REDOX START, Uncommment when you want to compile/check with redoxer
# # following patches are just waiting on a new version to be released to crates.io
# nix = { git = "https://github.com/nix-rust/nix" }
# crossbeam-utils = { git = "https://github.com/crossbeam-rs/crossbeam" }
# socket2 = { git = "https://github.com/alexcrichton/socket2-rs" }
# REDOX END

Loading