Repository navigation
Implementation of __init_subclass__ - #2017
Merged
Merged
Conversation
This doesn't support passing kwargs to __init_subclass__.
BolunThompson
changed the title
coolreader18
approved these changes
Jul 21, 2020
coolreader18
left a comment
coolreader18
left a comment
Member
There was a problem hiding this comment.
LGTM, are you done with this or still working on it?
Member
|
Oh, actually, would you be able to put the copied CPython test file in a separate commit? Something like
|
Contributor
Author
|
I'm done with this. I'll make that change now. |
Co-authored-by: Noah <33094578+coolreader18@users.noreply.github.com>
BolunThompson
force-pushed
the
init_subclass
branch
from
July 21, 2020 03:17
20cd6dc to
dd9eb28
Compare
Member
|
Thank you for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
__init_subclass__from PEP 487.Closes #1346. Partially fixes issue #356.