Incrementally adding OpenBSD support (pt. 1) #1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks like rustfmt isn't happy; try running |
Contributor
Author
|
Hmm, looks like the macos rust tests are failing. Do you know why this is? The interface doesn't really have much information. |
Member
|
It might've been something weird with push timing cancelling an old one; I'll rerun it. |
Member
|
Actually, it should fix itself if I just merge to master; it'll rerun CI then. Thanks so much for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1945, I mentioned some suggestions to improve support for OpenBSD. These are a bunch of minor changes, mostly adding some
#[cfg(target_os = "openbsd")]. Check out #1945 for more discussion, and stay tuned for more OpenBSD-related Pull Requests in the future.