Skip to content

Initialize the vm with imports from _io instead of io #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coolreader18 merged 1 commit into from
May 28, 2020
Merged

Initialize the vm with imports from _io instead of io #1942

coolreader18 merged 1 commit into from
May 28, 2020

Conversation

@coolreader18
Copy link
Member

@coolreader18 coolreader18 commented May 25, 2020

This should make debugging vm initialization problems easier.

auvipy
auvipy approved these changes May 28, 2020
View reviewed changes
Copy link

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coolreader18 coolreader18 merged commit 8452dbe into master May 28, 2020
@coolreader18 coolreader18 deleted the coolreader18/init-with-_io branch June 7, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palaviv palaviv palaviv approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coolreader18 @auvipy @palaviv