Move some vm fields to an Arc-wrapped struct #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
coolreader18/arc-vm-state
branch
from
27e5163 to
5f93f83
Compare
palaviv
approved these changes
May 22, 2020
| pub struct PyGlobalState { | ||
| pub settings: PySettings, | ||
| pub stdlib_inits: HashMap<String, stdlib::StdlibInitFunc>, | ||
| pub frozen: HashMap<String, bytecode::FrozenModule>, |
Contributor
There was a problem hiding this comment.
Maybe the frozen modules should be a global static? This should not change between VMs.
Member
Author
There was a problem hiding this comment.
Maybe, but it's possible that someone would want to inject a frozen module into one VM to wrap their API or something, but want to use another vm for something different. I've done that myself in another project that uses RustPython.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for threading; we want to keep some properties of the vm consistent across threads, so I'm moving the ones that should be into an
Arc.