The any key/whats left fix #1888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with master
coolreader18
approved these changes
Apr 27, 2020
Member
coolreader18
left a comment
coolreader18
left a comment
There was a problem hiding this comment.
This a very thorough fix, thank you for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has some symptomatic solution for the Issues
#1874
#1829
For #1874, I wrapped the import with an error handler and report this. The orignal cause is some import issue when importing the _pydecimal.py in that special context when importing it in a usual way it work well. So I guess it is either some kind of conflict with an other lib that is imported here or some vm issue in the context given by one or more of the other modules.
For #1829 I just added to set the path the readme. The rootcause is that the vm has some hardcoded import to 'io'. Seems that here the import is not considering the path without that environment variable.