Skip to content

Disable the unpack optimization #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
Apr 25, 2020
Merged

Disable the unpack optimization #1884

youknowone merged 2 commits into from
Apr 25, 2020

Conversation

@coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Apr 24, 2020

Fixes #1878

@palaviv
Copy link
Contributor

palaviv commented Apr 25, 2020

Let's add a test for this to avoid regression.

@youknowone youknowone merged commit e147d3e into master Apr 25, 2020
@youknowone youknowone deleted the coolreader18/disable-unpack-opt branch April 25, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tuple unpacking the result of an if expression is miscompiled, leads to panic

4 participants

@coolreader18 @palaviv @youknowone