Fix bytes.replace #1847
Merged
Fix bytes.replace #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
force-pushed
the
fix-bytes-replace
branch
2 times, most recently
from
c2ef0a2 to
758ae73
Compare
youknowone
force-pushed
the
fix-bytes-replace
branch
from
98788d8 to
5a1cf21
Compare
youknowone
force-pushed
the
fix-bytes-replace
branch
3 times, most recently
from
c99a11d to
c4a041e
Compare
youknowone
force-pushed
the
fix-bytes-replace
branch
from
c4a041e to
637c255
Compare
palaviv
approved these changes
Apr 18, 2020
| } | ||
|
|
||
| let result_len = self.len() - (count * from.len()); | ||
| debug_assert!(self.len() >= count * from.len()); |
Contributor
There was a problem hiding this comment.
maybe remove this? I know is is only in debug but it does not provide additional data.
Member
Author
There was a problem hiding this comment.
This is line by line port of CPython implementation. Do you still want to remove this regardless of it?
Contributor
There was a problem hiding this comment.
I am OK with you keeping this. Just not sure if that is necessary. Your call.
|
|
||
| // Check for overflow | ||
| // result_len = self_len + count * (to_len-from_len) | ||
| debug_assert!(count > 0); |
youknowone
force-pushed
the
fix-bytes-replace
branch
from
637c255 to
67a9dfd
Compare
palaviv
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.