Skip to content

Conversation

@coolreader18
Copy link
Member

Related to #1671

@coolreader18 coolreader18 force-pushed the coolreader18/jsontests branch from dae7a49 to f66fde5 Compare April 2, 2020 22:42
@coolreader18 coolreader18 requested a review from palaviv April 2, 2020 23:58
@ep12 ep12 mentioned this pull request Apr 3, 2020
8 tasks
@ep12
Copy link

ep12 commented Apr 3, 2020

See #1838 (example section):
This pr implements the code object co_varnames attribute, but the value differs from the ones cpython and pypy present...

@abitrolly
Copy link

Does it produce the result in real-time, or only after the processing is finished?

Is it a custom format, or something like https://chromium.googlesource.com/chromium/src.git/+/master/docs/testing/json_test_results_format.md was used for an inspiration?

@coolreader18
Copy link
Member Author

coolreader18 commented Apr 3, 2020

@abitrolly I'm not sure what you mean by your first question, but as to your second I think it's basically just the data that unittest outputs itself, converted to JSON. I didn't write the runner myself, I modified it from https://github.com/agramian/custom-text-test-runner, so I can't say for certain.

@coolreader18 coolreader18 merged commit f5de59a into master Apr 4, 2020
@coolreader18
Copy link
Member Author

@ep12 I'll look into fixing co_varnames separately.

@coolreader18 coolreader18 deleted the coolreader18/jsontests branch April 11, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants