Skip to content

Lib/test/test_types.py from CPython v3.8.1 #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowone merged 2 commits into from
Jan 31, 2020
Merged

Lib/test/test_types.py from CPython v3.8.1 #1721

youknowone merged 2 commits into from
Jan 31, 2020

Conversation

@youknowone
Copy link
Member

@youknowone youknowone commented Jan 30, 2020

No description provided.

@youknowone youknowone changed the title test_types.py from CPython v3.8.1 Lib/test/test_types.py from CPython v3.8.1 Jan 30, 2020
palaviv
palaviv approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would prefer marking tests with skip instead of comments out.

@youknowone youknowone merged commit c335791 into RustPython:master Jan 31, 2020
@youknowone youknowone deleted the test-types branch January 31, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palaviv palaviv palaviv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youknowone @palaviv