Skip to content

Add asyncio stdlib module#1594

Merged
coolreader18 merged 9 commits into
masterfrom
coolreader18/asyncio
Nov 23, 2019
Merged

Add asyncio stdlib module#1594
coolreader18 merged 9 commits into
masterfrom
coolreader18/asyncio

Conversation

@coolreader18

@coolreader18 coolreader18 commented Nov 12, 2019

Copy link
Copy Markdown
Member

Most of the Lib files are taken from CPython 3.6. To see just the changes to the stdlib files (or just the changes I actually made) you can look here; asyncio.runners and the changes to asyncio.tasks are taken from CPython 3.7.

@palaviv

palaviv commented Nov 15, 2019

Copy link
Copy Markdown
Contributor

This looks great @coolreader18. Can you split this PR into some smaller PRs?

@palaviv palaviv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

Comment thread Lib/selectors.py Outdated
Comment thread vm/src/stdlib/dis.rs
Comment thread vm/src/obj/objobject.rs
Comment thread vm/src/stdlib/socket.rs
use libc as c;
mod c {
pub use libc::*;
// TODO: open a PR to add these constants to libc; then just use libc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@coolreader18 coolreader18 force-pushed the coolreader18/asyncio branch 6 times, most recently from 1090f8d to ce65623 Compare November 21, 2019 23:39
@coolreader18 coolreader18 requested a review from palaviv November 22, 2019 02:38
@coolreader18

Copy link
Copy Markdown
Member Author

This should be all good now @palaviv

@coolreader18 coolreader18 force-pushed the coolreader18/asyncio branch 2 times, most recently from cdb4bc7 to 23bb5d5 Compare November 23, 2019 05:30
@coolreader18 coolreader18 merged commit 79b65e6 into master Nov 23, 2019
@coolreader18 coolreader18 deleted the coolreader18/asyncio branch December 1, 2019 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants