Set docstring of function as None if not declared #1580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cpython, if there is no docstring declared in function definition, the `__doc__` attribute of the function is None. So this implements the behavior. Fix RustPython#1523
Contributor
|
Great work @seeeturtle. This make the change in #1550 redundant so I would suggest removing it in a different PR. |
This was referenced Nov 2, 2019
Contributor
Author
|
@palaviv what do you mean to remove in different PR? |
Member
|
I think he's made the change in #1582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cpython, if there is no docstring declared in function definition,
the
__doc__attribute of the function is None.So this implements the behavior.
Fix #1523