objtype: Set __doc__ as None if not included #1550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set __doc__ as None if it is not included in attribute while making new instance of type. In cpython if there is no docstring in class definition, __doc__ attribute will be None. So RustPython should follow it. Partially solves RustPython#1523
HyeockJinKim
suggested changes
Oct 20, 2019
Contributor
HyeockJinKim
left a comment
HyeockJinKim
left a comment
There was a problem hiding this comment.
You should also write test code related to this code.
| let mut attributes = dict.to_attributes(); | ||
|
|
||
| // insert __doc__ as None if it is not included in attributes | ||
| if !attributes.contains_key("__doc__") { |
Contributor
There was a problem hiding this comment.
>>>>> def f():
..... pass
.....
>>>>> f.__doc__
'The most base type'The current code does not check the code above.
The expected result is shown below.
>>> def f():
... pass
...
>>> f.__doc__
>>>
Contributor
Author
There was a problem hiding this comment.
yes, this doesn't fixes the same problem in function.
I'm planning to handle that in another PR.
This only fixes class definition.
This was referenced Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set
__doc__as None if it is not included in attributewhile making new instance of type.
In cpython if there is no docstring in class definition,
__doc__attribute will be None. So RustPython should follow it.Partially solves #1523
This only fixes class definition.