Repository navigation
Implement round(number, digits) for digits != 0 - #1521
Merged
Merged
Conversation
Member
|
Thanks for contributing! Will you add some test cases about new code? There are python test snippets about float in |
Contributor
Author
|
Will do. Might be a few days though as I won't be home before wednesday |
janrg
force-pushed
the
round_to_n_decimals
branch
from
October 14, 2019 15:06
01dc6cc to
4fd38e6
Compare
Contributor
Author
|
Found some time to write a few tests and also noticed a range of input values where it wasn't working properly yet. Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For most cases uses rust's round function to round via:
round(number, decimals) = round(number * 10^decimals) / 10^decimalsdecimals