Repository navigation
Add RecursionError - #1477
Merged
Merged
Add RecursionError#1477
Conversation
coolreader18
approved these changes
Oct 5, 2019
coolreader18
left a comment
coolreader18
left a comment
Member
There was a problem hiding this comment.
This looks good, thanks for contributing!
| try: | ||
| recursive_call(300) | ||
| except RecursionError as exc: | ||
| pass |
Member
There was a problem hiding this comment.
You should use with assert_raises(RecursionError): ... here.
| pub use_tracing: RefCell<bool>, | ||
| pub signal_handlers: RefCell<[PyObjectRef; NSIG]>, | ||
| pub settings: PySettings, | ||
| pub recursion_limit: RefCell<usize>, |
Member
There was a problem hiding this comment.
This can just be a Cell<usize>
Contributor
Author
There was a problem hiding this comment.
It's much better! Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial solution of #1374
I made a small change to check recursion depth before push the frame and then raise error instead of run until segmentation fault occurs.
But it seems there is still a problem. RustPython occurs segmentation fault on 700 (debug) ~ 2600 (release) recursive calls while cpython is fine until 15000. This is the reason that I set default limit lower than cpython.
If there is any inappropriate changes, please let me know. Thank you.