Skip to content

Generate SyntaxError at integer starting with 0 #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windelbouwman merged 2 commits into from
Sep 28, 2019
Merged

Generate SyntaxError at integer starting with 0 #1430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8d0f5c
Generate SyntaxError at integer starting with 0
HyeockJinKim Sep 28, 2019
831c883
Add tests for integer
HyeockJinKim Sep 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion parser/src/lexer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ pub use super::token::Tok;
use crate::error::{LexicalError, LexicalErrorType};
use crate::location::Location;
use num_bigint::BigInt;
use num_traits::identities::Zero;
use num_traits::Num;
use std::cmp::Ordering;
use std::collections::HashMap;
Expand Down Expand Up @@ -352,7 +353,7 @@ where
/// Lex a normal number, that is, no octal, hex or binary number.
fn lex_normal_number(&mut self) -> LexResult {
let start_pos = self.get_pos();

let start_is_zero = self.chr0 == Some('0');
// Normal number:
let mut value_text = self.radix_run(10);

Expand Down Expand Up @@ -403,6 +404,12 @@ where
} else {
let end_pos = self.get_pos();
let value = value_text.parse::<BigInt>().unwrap();
if start_is_zero && !value.is_zero() {
return Err(LexicalError {
error: LexicalErrorType::OtherError("Invalid Token".to_string()),
location: self.get_pos(),
});
}
Ok((start_pos, Tok::Int { value }, end_pos))
}
}
Expand Down
21 changes: 21 additions & 0 deletions tests/snippets/ints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,3 +232,24 @@ def __int__(self):
assert_raises(TypeError, lambda: (1).__round__(None))
assert_raises(TypeError, lambda: (0).__round__(0.0))
assert_raises(TypeError, lambda: (1).__round__(0.0))

assert 00 == 0
assert 0_0 == 0
assert 03.2 == 3.2
assert 3+02j == 3+2j

# Invalid syntax:
src = """
b = 02
"""

with assert_raises(SyntaxError):
exec(src)

# Invalid syntax:
src = """
b = 03 + 2j
"""

with assert_raises(SyntaxError):
exec(src)