Generate SyntaxError at integer starting with 0#1430
Merged
Conversation
HyeockJinKim
force-pushed
the
issue1422
branch
from
84e9e26 to
01b6667
Compare
Generate syntaxError at integer starting with 0, not zero Fixes RustPython#1422
HyeockJinKim
force-pushed
the
issue1422
branch
from
a28841d to
831c883
Compare
Contributor
|
Nicely implemented! I'm still a bit clueless why a leading zero is not allowed. Do you have any ideas? |
Member
|
I think it's ambiguous/not explicit to whether the person writing it intended it to be a decimal literal or octal literal, as some languages take a leading 0 to mean octal, so they decided to ban it altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate syntaxError at integer starting with 0,
not zero
Fixes #1422