Repository navigation
impl __sizeof__ for bytearray, int, list and str - #1426
Merged
Merged
Conversation
windelbouwman
approved these changes
Sep 28, 2019
windelbouwman
left a comment
windelbouwman
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. Do you already want to merge this, or develop it further?
Contributor
Author
|
I planned on implementing the remaining sizeof methods as soon as I get some free time. |
| } | ||
|
|
||
| #[pymethod(name = "__sizeof__")] | ||
| fn sizeof(&self, _vm: &VirtualMachine) -> usize { |
Member
There was a problem hiding this comment.
Maybe use self.value.bits() and then round up to the nearest u64 for this.
Contributor
Author
There was a problem hiding this comment.
something like (self.value.bits() as f64 / 8.).ceil() as usize ?
Contributor
|
@RobertBerglund I would suggest to merge this work so far, otherwise this branch will be in a more conflicted status. |
Closed
33 of 35 tasks
ashermancinelli
added a commit
to ashermancinelli/RustPython
that referenced
this pull request
Oct 15, 2019
ashermancinelli
added a commit
to ashermancinelli/RustPython
that referenced
this pull request
Oct 15, 2019
ashermancinelli
added a commit
to ashermancinelli/RustPython
that referenced
this pull request
Oct 15, 2019
coolreader18
added a commit
that referenced
this pull request
Oct 17, 2019
`int.__sizeof__` from #1426
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress