Skip to content

builtin: Fix hex format of ascii #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
windelbouwman merged 3 commits into from
Jul 31, 2019
Merged

builtin: Fix hex format of ascii #1188

windelbouwman merged 3 commits into from
Jul 31, 2019

Conversation

@corona10
Copy link
Contributor

@corona10 corona10 commented Jul 28, 2019

Some range of Unicode characters should be specially handled

@corona10
Copy link
Contributor Author

corona10 commented Jul 28, 2019 •
edited
Loading

@windelbouwman

PTA
Sorry, I found some of more cases to deal with.
I will ping you after handling them

@corona10 corona10 changed the title builtin: Fix hex format of ascii [WIP] builtin: Fix hex format of ascii Jul 28, 2019
@corona10 corona10 changed the title [WIP] builtin: Fix hex format of ascii builtin: Fix hex format of ascii Jul 31, 2019
@corona10
Copy link
Contributor Author

corona10 commented Jul 31, 2019

@windelbouwman

PTAL

@windelbouwman
Copy link
Contributor

windelbouwman commented Jul 31, 2019

Hi @corona10 , what does PTA and PTAL mean?

windelbouwman
windelbouwman reviewed Jul 31, 2019
View reviewed changes
windelbouwman
windelbouwman reviewed Jul 31, 2019
View reviewed changes
@corona10
Copy link
Contributor Author

corona10 commented Jul 31, 2019

@windelbouwman

PTAL stands for 'Please take a look' :) (PTA was my typo.. sorry)
I 've updated your review, Thanks for the review with cool tips!

@windelbouwman windelbouwman merged commit c2ec66f into RustPython:master Jul 31, 2019
@corona10 corona10 deleted the hex_format branch July 31, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windelbouwman windelbouwman windelbouwman left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@corona10 @windelbouwman