Skip to content

freeze stdlib in WASM #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windelbouwman merged 2 commits into from
Jul 26, 2019
Merged

freeze stdlib in WASM #1180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321e43d
Add freeze-stdlib to wasm build
palaviv Jul 24, 2019
8f1df46
Freeze stdlib by default in WASM
palaviv Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions wasm/lib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ edition = "2018"
[lib]
crate-type = ["cdylib", "rlib"]

[features]
default = ["freeze-stdlib"]
freeze-stdlib = ["rustpython-vm/freeze-stdlib"]
Copy link
Contributor

@windelbouwman windelbouwman Jul 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of options! I think the name is good. Another viable name for this option might be include-stdlib to indicate the inclusion of the the standard library for people who are unfamiliar with the concept of freezing. But I think most people will probably know the idea of freeze.

This looks good to me!


[dependencies]
rustpython-compiler = { path = "../../compiler" }
rustpython-parser = { path = "../../parser" }
Expand Down