Skip to content

parser error handling improvements. #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
palaviv merged 1 commit into from
Jul 7, 2019
Merged

parser error handling improvements. #1112

palaviv merged 1 commit into from
Jul 7, 2019

Conversation

@windelbouwman
Copy link
Contributor

@windelbouwman windelbouwman commented Jul 6, 2019 •
edited
Loading

This improves error messages coming from f-string parsing.

Also grouped all error types into the error.rs file, and created a location.rs file.

@windelbouwman windelbouwman requested a review from palaviv July 6, 2019 18:19
@windelbouwman windelbouwman mentioned this pull request Jul 6, 2019
Closed
palaviv
palaviv approved these changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@palaviv palaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@palaviv palaviv merged commit e4322f5 into master Jul 7, 2019
@windelbouwman windelbouwman deleted the parser-error-cleaning branch September 1, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palaviv palaviv palaviv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@windelbouwman @palaviv