Repository navigation
Update typing to 3.12 #5252
Description
Feature
The typing module needs to be updated to 3.12. It seems that it was last updated to 3.9, so it's missing several major versions worth of features, like Unpack, generics, and type aliases using the type keyword.
Not having these typing features impedes the process of updating modules that use, which presumably will be most new stuff going forward.
I estimate that updating will require:
- Moving some abstract base classes from
typing.pyinto a new native moduletyping.rs, specificallyTypeVar,ParamSpec,TypeVarTuple,ParamSpecArgs,ParamSpecKwards,TypeAliasType, andGeneric. Adding new syntax likeIt seems like this is already included in https://github.com/RustPython/Parser/blob/main/parser/src/python.lalrpoptypetype aliases and generics to the parser.- Adding new instructions which generate/consume type information to
compiler.rsandframe.rs. For example,def foo[T](x: T): ...must create a newTypeVar(T)and inject it into the correct scope so that it is available as an argument annotation. This requires a new instruction defined inbytecode.rswhich is emitted bycompiler.rsand consumed byframe.rs. - Copying
typing.pyandtest_typing.pyfrom the CPython code base.
Python Documentation or reference to CPython source code
Reacted by Jeong, YunWon, Toni Alatalo and Theo Paris
Activity
dchiquito commentedon Apr 22, 2024
I've been chewing on this for a bit, but it's pretty slow going since I'm also learning about a lot of compilation internals. As soon as I have something that is mostly compatible with the 3.12
typing.pyI will submit a partial PR to get some incremental feedback.youknowone commentedon Apr 22, 2024
That's awesome. Please feel free to ask anything if you stuck on something.
About typing module, if it helps, mixing Rust and Python implementation is limited but still possible. #5254 is doing it for ExceptionGroup.
hydrogen602 commentedon May 12, 2024
I don't know if this is already known, but I just wanted to add to the 3.12 typing discussion that if not running in release mode, syntax like
def foo[T](): passcauses a panic in the parser atcore/src/source_code.rs:139:9dchiquito commentedon May 13, 2024
That problem should be resolved as of #5319 / RustPython/Parser#120. Thanks for reporting!
hbina commentedon Jan 31, 2025
Hi, what is the progress on this? Is there a way I can help? Trying to get started with RustPython myself :)
youknowone commentedon Jan 31, 2025
@hbina Hi, open
Lib/test/test_typing.pyin RustPython source code and search# TODO: RUSTPYTHONin the file. You will find many failing tests from there. Removing one of them will makecargo run -- Lib/test/test_typing.pybe failed. That's the starting point.Please share any blocker you meet. Thanks!
arihant2math commentedon Mar 31, 2025
#5590 should fix this.